Skip to content

Conversation

@KEINOS
Copy link

@KEINOS KEINOS commented Dec 25, 2024

Happy holidays!

This PR adds the workaround to avoid GoogleAuthentication's bug (fix #94).
Please review it when you got time.

@KEINOS
Copy link
Author

KEINOS commented Feb 28, 2025

Thinking twice, I think I should put the how-to on the wiki rather than adding an optional function to the package. Because the problem itself is not caused by our package, but by GoogleAuthenticator itself.

What do you think? --> @pquerna

@yogo1212
Copy link

@KEINOS just having the information is a little underwhelming since adapting will involve parsing and reassembling the url. this package is about otp and the google authenticator has a central role in the otp universe, whether we like it or not.

for some strange reason, this package started mangling the query parameters, pushing the secret to the back and exposing that strange behaviour of the google authenticator. forcing all users of the package to sift through the query parameters yet again is not a good solution.

@yogo1212
Copy link

@pquerna if you don't like this change, could you please let us know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OTP Generated by Google Authenticator not validated by the Library's OTP

2 participants