View-only mode works in react-native (with installed or shimmed react-dom)#368
Open
Shaddix wants to merge 3 commits intoprevwong:mainfrom
Open
View-only mode works in react-native (with installed or shimmed react-dom)#368Shaddix wants to merge 3 commits intoprevwong:mainfrom
Shaddix wants to merge 3 commits intoprevwong:mainfrom
Conversation
Shaddix
changed the title
Shaddix
changed the title
|
✔️ Deploy Preview for craftjs ready! 🔨 Explore the source changes: 32e0d5c 🔍 Inspect the deploy log: https://app.netlify.com/sites/craftjs/deploys/61f5734e3dc92100079f69dd 😎 Browse the preview: https://deploy-preview-368--craftjs.netlify.app |
prevwong
force-pushed
the
develop
branch
2 times, most recently
from
f09aac2 to
d8ad5cf
Compare
prevwong
force-pushed
the
develop
branch
8 times, most recently
from
af39d6c to
5f5223d
Compare
prevwong
force-pushed
the
main
branch
3 times, most recently
from
f14e620 to
84adfd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #363.
This is actually the only change that is needed for a library to work in react-native.
(secure id generation is not supported in react-native).
In react-native project there's still one thing needs to be done:
npm install react-dom(though it's never actually called unless you try to use Designer with RenderIndicator).react-domin react-native app using e.g. technique from the link(if it makes sense, these instructions could be added to README.MD)