Updated isMultiSelectEnabled to support ctrl key on windows#454
Open
amkoehler wants to merge 1 commit intoprevwong:mainfrom
Open
Updated isMultiSelectEnabled to support ctrl key on windows#454amkoehler wants to merge 1 commit intoprevwong:mainfrom
isMultiSelectEnabled to support ctrl key on windows#454amkoehler wants to merge 1 commit intoprevwong:mainfrom
Conversation
prevwong
force-pushed
the
main
branch
3 times, most recently
from
f14e620 to
84adfd1
Compare
|
ctrl key on windows still not working |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello - while testing beta, I found that the use of
metaKeyfor multi-selection does not work well on Windows. Generally the commands for metaKey on mac are equivalent to the ctrl key on windows, so I added a platform check usingnavigator.userAgent.