Adds native segwit script types #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Support for bitcoin 0.16 segWit transactions (decodeRawTransaction has boolean flag isWitness) -Change the inital sanity check from the depcreated getInfo() to getNetworkInfo() -Support for locally installing test jars, see README.md for details. Change pom.xml files to use SNAPSHOT version, as hopefully our jitpack can detail versioning.
* Remove estimateFee, new one is estimateSmartFee. Update jdk depedency and lombok * updates from PR comments
Add support to i2p network type
Taproot - add support to p2tp script
…address list when vout.size=1
Fix getRawTransaction with verbosity method in order to populate the …
Fix configurator
Deserialization of Untrusted Data (CVE-2019-17571)
Build fix: update lombok version
…n-btcd-cli4j-lib mmcc-918: fix critical vulnerability
Update RawTransaction.java
…SFTP URL in Maven artifact upload/download (#22) * Potential fix for code scanning alert no. 1: Failure to use HTTPS or SFTP URL in Maven artifact upload/download Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * Remove unused repository --------- Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BtcdClient.decodeRawTransaction raises an IllegalArgumentException on parsing native segwit script types: witness_v0_keyhash, witness_v0_scripthash
e.g.
java.lang.IllegalArgumentException: Error #1001010: Expected the argument to be a valid 'bitcoind' script type, but was invalid/unsupported instead. 2017-08-29 03:59:06.839431500 at com.neemre.btcdcli4j.core.domain.enums.ScriptTypes.forName(ScriptTypes.java:43)This patch adds the missing enums to fix.