Skip to content

ActionBar: Add ActionBar.Menu component #7065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

ActionBar: Add ActionBar.Menu component #7065

wants to merge 20 commits into from
+222 −8

Conversation

@TylerJDev
Copy link
Member

@TylerJDev TylerJDev commented Oct 23, 2025 •
edited
Loading

Closes https://github.com/github/primer/issues/5930

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8dfa896

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets
Name Type
@primer/react Patch
@primer/mcp Patch
@primer/styled-react Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 23, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-7065 October 23, 2025 14:59 Inactive
@pksjce pksjce self-requested a review October 24, 2025 01:51
pksjce
pksjce reviewed Oct 27, 2025
View reviewed changes
packages/react/src/ActionBar/ActionBar.tsx Outdated
}
| {type: 'divider'; width: number}
| {type: 'divider' | 'group' | 'menu'; width: number} // TODO: Can we combine this?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about this too. But I believe they have completely different functionality and the intention with each is different. I guess they do have a lot of similarity in implementation though

@github-actions github-actions bot requested a deployment to storybook-preview-7065 October 27, 2025 19:43 Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pksjce pksjce pksjce left review comments

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TylerJDev @pksjce