Skip to content

Conversation

@francinelucca
Copy link
Member

Found some remaining sx props in docs files, cleaning up 🧹

@francinelucca francinelucca requested a review from a team as a code owner October 29, 2025 01:11
@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2025

⚠️ No Changeset found

Latest commit: 839bb12

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@francinelucca francinelucca added the skip changeset This change does not need a changelog label Oct 29, 2025
@github-actions github-actions bot added the staff Author is a staff member label Oct 29, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes deprecated sx prop documentation entries from component documentation JSON files. The sx prop (of type SystemStyleObject) was previously deprecated but still documented. This cleanup aligns the documentation with the actual component interfaces, which no longer support the sx prop.

Key Changes:

  • Removed deprecated sx prop documentation from UnderlinePanels and its subcomponents
  • Removed deprecated sx prop documentation from deprecated components (UnderlineNav, FilteredSearch)

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/react/src/experimental/UnderlinePanels/UnderlinePanels.docs.json Removed deprecated sx prop from UnderlinePanels, UnderlinePanels.Tab, and UnderlinePanels.Panel documentation
packages/react/src/deprecated/UnderlineNav/UnderlineNav.docs.json Removed deprecated sx prop from UnderlineNav.Link documentation
packages/react/src/deprecated/FilteredSearch/FilteredSearch.docs.json Removed deprecated sx prop from FilteredSearch documentation

Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@francinelucca francinelucca added this pull request to the merge queue Oct 29, 2025
Merged via the queue into main with commit 57634df Oct 29, 2025
54 of 55 checks passed
@francinelucca francinelucca deleted the chore/docs-props-cleanup branch October 29, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants