Open
Conversation
| > | ||
| <Link | ||
| className="btn-text-color" | ||
| href="https://stg-erp.prixite.com/job_application/new?job_title=test-job" |
Contributor
There was a problem hiding this comment.
Use the env variable for the base url and job_title prop is not dynamic.
pages/jobs/[jobDetail].tsx
Outdated
|
|
||
| export const getServerSideProps = async (context: JobProps) => { | ||
| const name = context.params?.jobDetail | ||
| const url = `https://stg-erp.prixite.com/api/resource/Job%20Opening?fields=["*"]&filters=[["Job%20Opening","name","=","${name}"]]` |
Contributor
There was a problem hiding this comment.
base url should be added from env variables.
pages/jobs/index.tsx
Outdated
|
|
||
| export const getServerSideProps = async () => { | ||
| const url = | ||
| 'https://stg-erp.prixite.com/api/resource/Job%20Opening?fields=[%22*%22]' |
pages/jobs/index.tsx
Outdated
| import Link from 'next/link' | ||
| import Head from 'next/head' | ||
| import React from 'react' | ||
| import { JobProps } from '../../types/interfaces' |
Contributor
There was a problem hiding this comment.
Can't we add absolute urls here?
Contributor
There was a problem hiding this comment.
Constants should be coming from any constants utils file.
pages/jobs/[jobDetail].tsx
Outdated
| <Box className="header"> | ||
| <Box className="heading"> | ||
| <Typography className="heading-text"> | ||
| {result?.data[0].job_title} 🚀 |
Contributor
There was a problem hiding this comment.
You should add validation ? after data[0] as well
umairjameelprixite
approved these changes
Aug 21, 2023
Contributor
umairjameelprixite
left a comment
umairjameelprixite
left a comment
There was a problem hiding this comment.
Code seems fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.