Skip to content

Homework- Giovanni Soto#12

Open
gsrok wants to merge 1 commit intoprofstein:masterfrom
gsrok:master
Open

Homework- Giovanni Soto#12
gsrok wants to merge 1 commit intoprofstein:masterfrom
gsrok:master

Conversation

@gsrok
Copy link

@gsrok gsrok commented Feb 10, 2014

No description provided.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no opening mainContent div. Either add the opening or remove this.

@profstein
Copy link
Owner

Overall this is a good start. Look over the inline comments and revise it. Your answers to the questions are good. For the two websites you chose the only thing missing were specific references to the actual elements of the page that allowed you to come to your conclusion. For example you write that Bar Camp Omaha has " friendly, fun, and thoughtful design." What makes it friendly fun and thoughtful? Colors, Illustrations, photos, text? As you are able to be more specific in your descriptions it helps you to see what other designers are doing, be more thoughtful about your design and hopefully speak more clearly about your own designs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants