-
Notifications
You must be signed in to change notification settings - Fork 20
Add support to sort the test run execution list and retrieve all records without pagination #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2.15-develop
Are you sure you want to change the base?
Add support to sort the test run execution list and retrieve all records without pagination #286
Conversation
Summary of ChangesHello @rquidute, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces sorting and 'get all' functionality to the test run executions endpoint. The implementation is sound and includes new tests. My review includes a correction for a bug in one of the new tests that prevents it from correctly verifying the sort order, and a couple of minor improvements to type hints for better code clarity.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…icable unit tests failing due to race condition
antonio-amjr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider the following.
Let me know if you disagree.
test_collections/matter/sdk_tests/support/python_testing/models/python_test_parser.py
Outdated
Show resolved
Hide resolved
|
@rquidute, Did you try this solution with a execution of different projects IDS and running from several different folders? |
antonio-amjr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the below:
| ) | ||
| ) | ||
|
|
||
| if order_by is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the suggestion below possible to substitute this whole conditional?
What do you think?
| if order_by is None: | |
| column = self.model.id if order_by is None else getattr(self.model, order_by) | |
| if sort_order == "desc": | |
| query = query.order_by(column.desc()) | |
| else: | |
| query = query.order_by(column.asc()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, take a look in the suggestion above 👆
Approving either way
What changed
This PR adds sort ordering functionality and the possibility to retrieve all test run execution records.
backwards compatibility
Related Issue
project-chip/certification-tool#823
Testing