Fix memory leaks on error #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly due to memory leaks being reported happening in case of parsing errors.
Required to clean up temp nodes/values if a parsing error occurs, as some aren't attached to the root node of the compiled expression tree yet.
kblaschke
force-pushed
the
fix-memory-leaks-on-error
branch
from
c4fdaad to
1fda496
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a parsing error was encountered, temporary nodes created in that syntax branch weren't properly free'd. Added
%destructorsymbols in the parser definition so the generated parser will now correctly clean up those pointers in case of errors.