Skip to content

oci-register-machine: Get hook stage from stdin's 'status' value #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wking wants to merge 1 commit into
base: master
Choose a base branch
from
Open

oci-register-machine: Get hook stage from stdin's 'status' value #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 6 additions & 14 deletions oci-register-machine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ var conn *dbus.Conn
type State struct {
Version string `json:"version"`
ID string `json:"id"`
Status string `json:"status"`
Pid int `json:"pid"`
Root string `json:"root"`
Bundle string `json:"bundle"`
Expand Down Expand Up @@ -121,16 +122,7 @@ func main() {
log.Fatalf("RegisterMachine Failed %m")
}

stage := map[bool]string{true: "prestart", false: "poststop"}[state.Pid > 0]
if env, ok := os.LookupEnv("stage"); ok {
stage = env
} else {
if len(os.Args) > 1 {
stage = os.Args[1]
}
}

log.Printf("Register machine: %s %s %d %s", stage, state.ID, state.Pid, state.Root)
log.Printf("Register machine: %s %s %d %s", state.ID, state.Status, state.Pid, state.Root)
passId := state.ID
// If id is shorter than 32, then read container_uuid from the container process environment variables
if len(passId) < 32 && state.Pid > 0 {
Expand Down Expand Up @@ -163,15 +155,15 @@ func main() {
log.Fatalf("RegisterMachine Failed %m")
}

switch stage {
case "prestart":
switch state.Status {
case "created":
{
if err = RegisterMachine(state.ID, passId, int(state.Pid), state.Root); err != nil {
log.Fatalf("Register machine failed: %m")
}
return
}
case "poststop":
case "stopped":
{
if err := TerminateMachine(state.ID); err != nil {
if !strings.Contains(err.Error(), "No machine") {
Expand All @@ -180,6 +172,6 @@ func main() {
}
return
}
log.Printf("Does not support the %q stage must be prestart|poststop", stage)
}
log.Printf("Does not support the %q status must be created|stopped", state.Status)
}