Final Submission for BackBone Youtube Project#101
Open
JBStover wants to merge 4 commits intoprojectshft:masterfrom
Open
Final Submission for BackBone Youtube Project#101JBStover wants to merge 4 commits intoprojectshft:masterfrom
JBStover wants to merge 4 commits intoprojectshft:masterfrom
Conversation
elbaumpj
approved these changes
Sep 27, 2021
elbaumpj
left a comment
elbaumpj
left a comment
There was a problem hiding this comment.
good work! mostly just a few stylistic things
| }, | ||
|
|
||
| initialRender: function () { | ||
| this.model.setCurrentVideo(1); |
There was a problem hiding this comment.
I think this should be a zero, I'm getting the second video on initial render
|
|
||
| }); | ||
|
|
||
| // <iframe width="500" height="315" src="https://www.youtube.com/embed/{{ videoId }}" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe> No newline at end of file |
| } | ||
| }, | ||
|
|
||
|
|
Comment on lines
+31
to
+34
| //API key = | ||
|
|
||
| //Sample request URL = https://www.googleapis.com/youtube/v3/search?part=snippet&maxResults=5&q=SEARCH_TERM_HERE&type=video&videoEmbeddable=true&key=AIzaSyCzOpDEiGvKbh687SDR3qDRwKWsbnqKCDU | ||
| //<iframe width="560" height="315" src="https://www.youtube.com/embed/ {{ id }}" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe> No newline at end of file |
Comment on lines
+30
to
+33
|
|
||
|
|
||
|
|
||
|
|
elbaumpj
reviewed
Sep 27, 2021
Comment on lines
+23
to
+26
| console.log('Thumbnail clicked'); | ||
| console.log(clickedVideoId); | ||
| this.model.updateCurrentVideo(clickedVideoId); | ||
| console.log(this.model.get('current_video')); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.