Open
Conversation
elbaumpj
reviewed
Mar 28, 2022
elbaumpj
left a comment
elbaumpj
left a comment
There was a problem hiding this comment.
Good work! A few small suggestions to keep in mind for the future :)
| 'keyup #search-query': 'handleEnterKey', | ||
| }, | ||
|
|
||
| results: `https://www.googleapis.com/youtube/v3/search?part=snippet&maxResults=5&type=video&videoEmbeddable=true&key=AIzaSyBKNZGIlCDmF6OqxU4eU4NsIcvV5Lx1SCw&q=`, |
There was a problem hiding this comment.
This works fine; you could also search on the collection if you wanted.
| /* eslint-disable no-plusplus */ | ||
| /* eslint-disable object-shorthand */ | ||
|
|
||
| var VideosModel = Backbone.Model.extend({ |
There was a problem hiding this comment.
I would call this Video (singular) model; a nit pick, but something to keep in mind.
| defaults: function () { | ||
| return { | ||
| videos: new VideosCollection(), | ||
| videoResult: null, |
There was a problem hiding this comment.
I would possibly call this something like selectedVideo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.