Open
Conversation
elbaumpj
reviewed
Mar 28, 2022
elbaumpj
left a comment
elbaumpj
left a comment
There was a problem hiding this comment.
Good work! A few suggestions for you, overall very well done.
|
|
||
| model: VideoModel, | ||
|
|
||
| addVideos: function (id, img, title, description) { |
There was a problem hiding this comment.
As far as I can tell, addVideos isn't completely necessary. There's some magic happening on the fetch that connects collection and model.
| loadVideos: function () { | ||
| var items = sampleData.items; | ||
|
|
||
| for (i = 0; i < items.length; i++) { |
There was a problem hiding this comment.
Since you mutate data in the parse function in the collection, I'm not sure you need to do this here.
| img: '', | ||
| title: '', | ||
| description: '', | ||
| isMainVideo: false |
There was a problem hiding this comment.
You could update the selected video on click without using the isMainVideo property - this is a slightly more roundabout approach
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.