Skip to content

eval submission#148

Open
jordanccox wants to merge 70 commits intoprojectshft:masterfrom
jordanccox:master
Open

eval submission#148
jordanccox wants to merge 70 commits intoprojectshft:masterfrom
jordanccox:master

Conversation

@jordanccox
Copy link

No description provided.

// Create fake data for API testing

/**
* Creates 90 fake products
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work on function documentation

product.image = "https://via.placeholder.com/250?text=Product+Image";
product.reviews = [];

try {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job using try catch

case "highest":
aggSort.$sort.price = -1;
break;
default:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to see you included a default case

};

const showNavItems = () => {
if (hidden === "hidden") {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also use a ternary here
hidden === "hidden" ? setHidden("") : setHidden("hidden");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants