[kube-state-metrics] align metricAnnotationsAllowlist naming#6721
Open
firasmosbehi wants to merge 1 commit intoprometheus-community:mainfrom
Open
[kube-state-metrics] align metricAnnotationsAllowlist naming#6721firasmosbehi wants to merge 1 commit intoprometheus-community:mainfrom
firasmosbehi wants to merge 1 commit intoprometheus-community:mainfrom
Conversation
Signed-off-by: Firas Mosbehi <firas.mosbehi@insat.ucar.tn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the normalized
metricAnnotationsAllowlistvalues key tokube-state-metricswhile preserving backward compatibility with the existingmetricAnnotationsAllowListkey, addressing #5651.Problem
The chart uses
metricAnnotationsAllowListwhile related options use theAllowlistcasing convention. This is inconsistent and causes confusion.Root cause
The value and template wiring were implemented only with the older
AllowListcasing.Fix
metricAnnotationsAllowlisttovalues.yaml.metricAnnotationsAllowListas a deprecated compatibility alias.metricAnnotationsAllowlistand fall back tometricAnnotationsAllowList.7.2.0to7.2.1.Validation
helm lint charts/kube-state-metricshelm template test charts/kube-state-metrics --set-string 'metricAnnotationsAllowlist[0]=pods=[kubernetes.io/team]'helm template test charts/kube-state-metrics --set-string 'metricAnnotationsAllowList[0]=pods=[legacy/key]'--metric-annotations-allowlist=...argument.Compatibility
Backward compatible by design: existing users of
metricAnnotationsAllowListcontinue to work.