Skip to content

Use cloud.google.com/go/monitoring/apiv3 for metrics APIs #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Use cloud.google.com/go/monitoring/apiv3 for metrics APIs #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions collectors/delta_counter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (

"github.com/go-kit/log"
"github.com/go-kit/log/level"
"google.golang.org/api/monitoring/v3"
"google.golang.org/genproto/googleapis/api/metric"
)

type CollectedMetric struct {
Expand All @@ -36,7 +36,7 @@ type DeltaCounterStore interface {

// Increment will use the incoming metricDescriptor and currentValue to either create a new entry or add the incoming
// value to an existing entry in the underlying store
Increment(metricDescriptor *monitoring.MetricDescriptor, currentValue *ConstMetric)
Increment(metricDescriptor *metric.MetricDescriptor, currentValue *ConstMetric)

// ListMetrics will return all known entries in the store for a metricDescriptorName
ListMetrics(metricDescriptorName string) map[string][]*CollectedMetric
Expand All @@ -62,7 +62,7 @@ func NewInMemoryDeltaCounterStore(logger log.Logger, ttl time.Duration) DeltaCou
}
}

func (s *inMemoryDeltaCounterStore) Increment(metricDescriptor *monitoring.MetricDescriptor, currentValue *ConstMetric) {
func (s *inMemoryDeltaCounterStore) Increment(metricDescriptor *metric.MetricDescriptor, currentValue *ConstMetric) {
if currentValue == nil {
return
}
Expand Down
6 changes: 3 additions & 3 deletions collectors/delta_distribution.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import (

"github.com/go-kit/log"
"github.com/go-kit/log/level"
"google.golang.org/api/monitoring/v3"
"google.golang.org/genproto/googleapis/api/metric"
)

type CollectedHistogram struct {
Expand All @@ -36,7 +36,7 @@ type DeltaDistributionStore interface {

// Increment will use the incoming metricDescriptor and currentValue to either create a new entry or add the incoming
// value to an existing entry in the underlying store
Increment(metricDescriptor *monitoring.MetricDescriptor, currentValue *HistogramMetric)
Increment(metricDescriptor *metric.MetricDescriptor, currentValue *HistogramMetric)

// ListMetrics will return all known entries in the store for a metricDescriptorName
ListMetrics(metricDescriptorName string) map[string][]*CollectedHistogram
Expand All @@ -62,7 +62,7 @@ func NewInMemoryDeltaDistributionStore(logger log.Logger, ttl time.Duration) Del
}
}

func (s *inMemoryDeltaDistributionStore) Increment(metricDescriptor *monitoring.MetricDescriptor, currentValue *HistogramMetric) {
func (s *inMemoryDeltaDistributionStore) Increment(metricDescriptor *metric.MetricDescriptor, currentValue *HistogramMetric) {
if currentValue == nil {
return
}
Expand Down
Loading