notify: use tick time in dedup repeat checks #4864
Open
+39
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now) for dedup repeat-interval checks.Background
Issue #2461 reports
TestRetryconsistently failing on Darwin due to repeat notifications occurring earlier than expected.Root Cause
DedupStagerelied ontime.Now()instead of the dispatcher-provided tick time. When the pipeline execution is delayed on Darwin, the repeat interval appears to have already elapsed, causing an early resend.Fix
DedupStagenow prefers the contextNowvalue (set by dispatch) and falls back to its internal clock when absent, making repeat-interval decisions deterministic.Testing
ldLC_DYSYMTAB warnings)Fixes #2461.