fix(encoding): do not encode descriptor of empty family #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoutn1k
force-pushed
the
spoutn1k/svelte-encoding
branch
2 times, most recently
from
d17742b to
2f0b0ab
Compare
mxinden
reviewed
Aug 14, 2025
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Thanks for the patch.
Needs a test and a changelog entry.
In addition, can you point to the corresponding code in the Golang client?
TymanWasTaken
added a commit
to Polyfrost/backend
that referenced
this pull request
Aug 16, 2025
spoutn1k
force-pushed
the
spoutn1k/svelte-encoding
branch
from
2f0b0ab to
1d7f079
Compare
Contributor
Author
|
Seems like the go code doing this is here: https://github.com/prometheus/client_golang/blob/84a4734fe73aecc9ec36e1fbcb09c9a2d679f392/prometheus/internal/metric.go#L82-L101 |
spoutn1k
force-pushed
the
spoutn1k/svelte-encoding
branch
5 times, most recently
from
27e9c41 to
74c450a
Compare
mxinden
changed the title
mxinden
reviewed
Sep 2, 2025
Member
|
I don't have permissions to apply the above suggestions. Mind granting me those permissions, or applying them yourself? |
spoutn1k
force-pushed
the
spoutn1k/svelte-encoding
branch
from
74c450a to
2109c5d
Compare
Signed-off-by: Jean-Baptiste Skutnik <jskutnik@ddn.com>
Signed-off-by: Jean-Baptiste Skutnik <jskutnik@ddn.com>
spoutn1k
force-pushed
the
spoutn1k/svelte-encoding
branch
from
2109c5d to
82e1d7c
Compare
Contributor
Author
|
I rebased and applied the changes in the mix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #271. The implementation should be extensible and a user choice when implementing
is_emptyon theEncodeMetrictrait. This disables metric descriptor generation on families. The original issue does not make clear if this is an implementation choice or a bug, I can feature-gate the change if this is a choice.