Added Bucket-config as a configmap in a Block-sync init container.#810
Closed
kushalShukla-web wants to merge 0 commit intoprometheus:masterfrom
Closed
Added Bucket-config as a configmap in a Block-sync init container.#810kushalShukla-web wants to merge 0 commit intoprometheus:masterfrom
kushalShukla-web wants to merge 0 commit intoprometheus:masterfrom
Conversation
kushalShukla-web
changed the title
kushalShukla-web
force-pushed
the
blocksync/yml
branch
from
39e9543 to
41a380d
Compare
kushalShukla-web
changed the title
kushalShukla-web
force-pushed
the
blocksync/yml
branch
from
754a235 to
78397b0
Compare
kakkoyun
reviewed
Jan 29, 2025
| - name: bucket-config # Define the Secret volume | ||
| secret: | ||
| secretName: bucket-secret | ||
| - name: key |
Member
There was a problem hiding this comment.
Suggested change
| - name: key | |
| - name: blocksync-location-key |
The above is just an example.
Let's be more specific. key is too generic.
kushalShukla-web
force-pushed
the
blocksync/yml
branch
4 times, most recently
from
2edc15b to
04d1941
Compare
kushalShukla-web
force-pushed
the
blocksync/yml
branch
from
04d1941 to
12d071e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following prometheus/test-infra#779 and prometheus/prometheus#15183, the placement of the
bucket-configfile in the Prometheus repository has created some inconsistencies, such as:bucket-configfile is required in multiple parts of PromBench, such as the Load Generator to query downloaded block data. This leads to downloading the entire Prometheus repository, which is not an efficient solution.To address these issues, I have moved all bucket configuration into a ConfigMap.