Add documentation generation to GitHub's build-and-test #2190
Conversation
|
Test failed in the expected way. Going to rebase on top of #2189 to ensure it passes. |
artwyman
force-pushed
the
artwyman/docs-test
branch
from
4550ead to
97e4875
Compare
|
I'm confused by the repeat failure. Seems like it's showing the same issue fixed in the parent PR, which I don't see when I test locally. Going to try tweaking a few things. |
|
Ah, I now suspect some interaction of force-push with the attempt by GitHub to block me pushing workflow changes with a client not authorized for them. Let's see what I can do with the GitHub client. |
artwyman
force-pushed
the
artwyman/docs-test
branch
from
7926a8c to
dce1f45
Compare
The config file changes related to include paths are what fixed the actual error. See #2190 for a proposed workflow change to detect this kind of breakage on PRs. I also addressed many (but not all) of the doc-generation warnings and broken links.
artwyman
force-pushed
the
artwyman/docs-test
branch
from
dce1f45 to
cccf4fb
Compare
|
Rebased after the parent PR merged. This is ready to review and merge @robknight |
artwyman
force-pushed
the
artwyman/docs-test
branch
from
cccf4fb to
1f04710
Compare
|
This got forgotten but I'd like to resurrect it now. While not a priority, the intent of making sure our generated docs don't break when code changes seems a good one. I just rebased and force-pushed to confirm that this still passes on the latest state of main. |
|
When I run |
Expected to fail on the current state of main. Fix incoming in #2189, but I want to confirm this test would catch the issue.