Add proofcast adapter #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubordignon
reviewed
Jun 14, 2024
| if (yahos[domain] == address(0)) revert UnsupportedChainId(domain); | ||
|
|
||
| offset += 32; // skip the event id (32 bytes) | ||
| bytes memory eventBytes = statement[offset:]; |
There was a problem hiding this comment.
From the statement format, you should have the event id at this offset.
Collaborator
Author
There was a problem hiding this comment.
isn't it skipped on line 95?
There was a problem hiding this comment.
My bad, I overlooked offset += 32 at line 91.
Resolving this and the other comment, which was also tied to the fact that I didn't spot the event id skipping.
ubordignon
reviewed
Jun 14, 2024
ubordignon
reviewed
Jun 17, 2024
|
|
||
| // MessageDispatched event parsing | ||
| address yahoAddress = RLPReader.toAddress(eventContent[0]); | ||
| if (yahoAddress != yahos[domain]) revert InvalidYahoAddress(); |
There was a problem hiding this comment.
This is my last comment, everything else LGTM!
Collaborator
Author
There was a problem hiding this comment.
Good catch, thank you, I'll sort it out in the afternoon
gitmp01
force-pushed
the
feat/add-proofcast-adapter
branch
from
a69d98f to
7244cd9
Compare
ubordignon
reviewed
Jun 18, 2024
| error InvalidMessageId(uint256 actual, uint256 expected); | ||
| error InvalidDestinationChainId(uint256 chainId); | ||
| error GracePeriodNotElapsed(); | ||
| error InvalidNewTeeSigner(); |
There was a problem hiding this comment.
Out of completeness you could include a test for this new error type as well, although it is not necessary, as applyNewTeeSigner is very straight forward.
| error UnsupportedProtocolId(bytes1 protocolId); | ||
| error UnsupportedChainId(uint256 chainId); | ||
| error UnexpectedEventTopic(bytes32 topic); | ||
| error InvalidSender(); |
| error UnexpectedEventTopic(bytes32 topic); | ||
| error InvalidSender(); | ||
| error InvalidMessageId(uint256 actual, uint256 expected); | ||
| error InvalidDestinationChainId(uint256 chainId); |
| import { Ownable } from "@openzeppelin/contracts/access/Ownable.sol"; | ||
| import { ECDSA } from "@openzeppelin/contracts/utils/cryptography/ECDSA.sol"; | ||
| import { RLPReader } from "solidity-rlp/contracts/RLPReader.sol"; | ||
| import { IERC777Recipient } from "@openzeppelin/contracts/interfaces/IERC777Recipient.sol"; |
| import { ECDSA } from "@openzeppelin/contracts/utils/cryptography/ECDSA.sol"; | ||
| import { RLPReader } from "solidity-rlp/contracts/RLPReader.sol"; | ||
| import { IERC777Recipient } from "@openzeppelin/contracts/interfaces/IERC777Recipient.sol"; | ||
| import { IERC1820RegistryUpgradeable } from "@openzeppelin/contracts-upgradeable/interfaces/IERC1820RegistryUpgradeable.sol"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What to look:
ProofcastAdapter.soltest/adapters/Proofcasttest/adapters/Proofcast/EventAttestator.ts