clippy: integrated clippy using rules_lint#13
Closed
saksham-chawla wants to merge 2 commits intocodex/replay-pr-154-basefrom
Closed
clippy: integrated clippy using rules_lint#13saksham-chawla wants to merge 2 commits intocodex/replay-pr-154-basefrom
saksham-chawla wants to merge 2 commits intocodex/replay-pr-154-basefrom
Conversation
incorporated in the .bazelrc added new workflow Signed-off-by: Dan Calavrezo <195309321+dcalavrezo-qorix@users.noreply.github.com>
uplifted msrv to 1.90.0 Signed-off-by: Dan Calavrezo <195309321+dcalavrezo-qorix@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
incorporated in the .bazelrc
added new workflow
Integrate Clippy for Rust Code Quality and Fix FFI Mutability
This pull request integrates Clippy, a Rust linter, into the project's Bazel build system and CI/CD pipeline. It introduces a new GitHub Actions workflow for automated Clippy checks on pull requests and pushes to
main. The.bazelrcis updated to enable Clippy by default for Rust targets and provides a strict lint configuration. Additionally, a minor fix related to mutable FFI pointer handling inruntime.rswas applied, likely identified or prompted by linting considerations, and theREADME.mdwas updated to document the new Clippy setup.Architecture Diagram:
flowchart TD subgraph CI_CD_Layer A["GitHub Workflow (.github/workflows/clippy.yml +28)"] -- triggers --> B["Bazel Clippy Job"] end subgraph Build_System_Layer B -- uses config --> C[".bazelrc (+5)"] C -- configures --> D["aspect_rules_lint (v2.0.0)"] C -- uses policies from --> E["score_rust_policies (new dep)"] D -- applies linting to --> F["Rust Runtime Code (runtime.rs +3/-10)"] end subgraph Documentation_Layer H["README.md (+8/-1)"] -- documents --> C H -- documents --> F end D -- depends on --> EThis summary was automatically generated by @propel-code-bot