Skip to content

clippy: integrated clippy using rules_lint#13

Closed
saksham-chawla wants to merge 2 commits intocodex/replay-pr-154-basefrom
codex/replay-pr-154-head
Closed

clippy: integrated clippy using rules_lint#13
saksham-chawla wants to merge 2 commits intocodex/replay-pr-154-basefrom
codex/replay-pr-154-head

Conversation

@saksham-chawla
Copy link
Collaborator

@saksham-chawla saksham-chawla commented Mar 18, 2026

incorporated in the .bazelrc
added new workflow


Integrate Clippy for Rust Code Quality and Fix FFI Mutability

This pull request integrates Clippy, a Rust linter, into the project's Bazel build system and CI/CD pipeline. It introduces a new GitHub Actions workflow for automated Clippy checks on pull requests and pushes to main. The .bazelrc is updated to enable Clippy by default for Rust targets and provides a strict lint configuration. Additionally, a minor fix related to mutable FFI pointer handling in runtime.rs was applied, likely identified or prompted by linting considerations, and the README.md was updated to document the new Clippy setup.

Architecture Diagram:

flowchart TD
    subgraph CI_CD_Layer
        A["GitHub Workflow (.github/workflows/clippy.yml +28)"] -- triggers --> B["Bazel Clippy Job"]
    end

    subgraph Build_System_Layer
        B -- uses config --> C[".bazelrc (+5)"]
        C -- configures --> D["aspect_rules_lint (v2.0.0)"]
        C -- uses policies from --> E["score_rust_policies (new dep)"]
        D -- applies linting to --> F["Rust Runtime Code (runtime.rs +3/-10)"]
    end

    subgraph Documentation_Layer
        H["README.md (+8/-1)"] -- documents --> C
        H -- documents --> F
    end

    D -- depends on --> E
Loading

This summary was automatically generated by @propel-code-bot

incorporated in the .bazelrc
added new workflow

Signed-off-by: Dan Calavrezo <195309321+dcalavrezo-qorix@users.noreply.github.com>
uplifted msrv to 1.90.0

Signed-off-by: Dan Calavrezo <195309321+dcalavrezo-qorix@users.noreply.github.com>
@saksham-chawla saksham-chawla marked this pull request as ready for review March 18, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants