Adds GetLatestSample function#3
Closed
saksham-chawla wants to merge 3 commits intocodex/replay-pr-204-basefrom
Closed
Adds GetLatestSample function#3saksham-chawla wants to merge 3 commits intocodex/replay-pr-204-basefrom
saksham-chawla wants to merge 3 commits intocodex/replay-pr-204-basefrom
Conversation
- Adds GetLatestSlot function to EventDataControlComposite Issue: SWP-249517
- Adds GetLatestSampleFunction to SkeletonEvent Issue: SWP-249517
- fixes clang format issues. Issue: SWP-249517
saksham-chawla
pushed a commit
that referenced
this pull request
Mar 18, 2026
…_implementation_Feedback_Review Address review feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds GetLatestSample function
This pull request introduces a new
GetLatestSample()function to theSkeletonEventBindinginterface and itslola::SkeletonEventimplementation. This function allows consumers to retrieve the most recently sent sample from an event. It also adds a newGetLatestSlot()function toEventDataControlCompositeImplto find the latest readable slot, which is then utilized byGetLatestSample(). Extensive unit tests have been added to validate this new functionality across various scenarios.Architecture Diagram:
flowchart TD subgraph API_Layer A["SkeletonEvent (+10 lines)"] --"delegates GetLatestSample"--> B["SkeletonEventBinding (+2 lines)"] end subgraph Service_Layer B["SkeletonEventBinding (+2 lines)"] --"implemented by"--> C["lola::SkeletonEvent (+38 lines)"] C --"calls GetLatestSlot"--> D["EventDataControlComposite (+2 lines)"] C --"accesses data"--> E[("EventDataStorage")] end subgraph Control_Layer D["EventDataControlComposite (+2 lines)"] --"manages"--> F["EventDataControl"] D --"uses"--> G["EventSlotStatus"] D --"finds latest slot"--> H["FindLatestReadableSlotIndex (+19 lines)"] D --"increments ref count"--> I["TryIncreaseReferenceCount (+13 lines)"] end subgraph Test_Layer J["lola::SkeletonEvent_test (+50 lines)"] --"tests"--> C K["EventDataControlComposite_test (+68 lines)"] --"tests"--> D L["SkeletonEvent_test (+54 lines)"] --"tests"--> A M["SkeletonEventBinding_test (+4 lines)"] --"tests"--> B endThis summary was automatically generated by @propel-code-bot