Skip to content

Adopt sanitizers from @score_cpp_policies#7

Closed
saksham-chawla wants to merge 3 commits intocodex/replay-pr-182-basefrom
codex/replay-pr-182-head
Closed

Adopt sanitizers from @score_cpp_policies#7
saksham-chawla wants to merge 3 commits intocodex/replay-pr-182-basefrom
codex/replay-pr-182-head

Conversation

@saksham-chawla
Copy link
Collaborator

@saksham-chawla saksham-chawla commented Mar 18, 2026

Adopt Centralized Sanitizer Policies from @score_cpp_policies

This pull request refactors the project's Bazel build system to adopt centralized sanitizer policies from the external @score_cpp_policies module. It removes a significant amount of local boilerplate related to AddressSanitizer (ASan), ThreadSanitizer (TSan), UndefinedBehaviorSanitizer (UBSan), and LeakSanitizer (LSan) configurations, including build rules, test workspaces, and environment templates. The project now leverages the external module for core sanitizer setup, while retaining a mechanism for project-specific suppressions.

Architecture Diagram:

flowchart TD
    subgraph Build_System
        M["MODULE.bazel (+10 lines)"]
        SCP["@score_cpp_policies"]
        QSB["quality/sanitizer/BUILD (+7 lines)"]
        QSSB["quality/sanitizer/sanitizer.bazelrc (+32 lines)"]
    end

    subgraph Integration_Testing
        QISSB["quality/integration_testing/sanitizer_support/BUILD (+10 lines)"]
        QIIB["quality/integration_testing/integration_testing.bzl (+4 lines)"]
        AT["Application_Tests (-12 lines)"]
    end

    M -->|adds dependency| SCP
    QSSB -->|imports configs from| SCP
    QSB -->|defines local suppressions| QISSB
    QISSB -->|combines suppressions from| SCP
    QIIB -->|uses configs from| SCP
    QIIB -->|uses suppressions from| QISSB
    AT -->|uses integration_test rule| QIIB
Loading

This summary was automatically generated by @propel-code-bot

saksham-chawla pushed a commit that referenced this pull request Mar 18, 2026
…_implementation_Feedback_Review

Generic skeleton implementation feedback review
@saksham-chawla saksham-chawla marked this pull request as ready for review March 18, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants