Adopt sanitizers from @score_cpp_policies#7
Closed
saksham-chawla wants to merge 3 commits intocodex/replay-pr-182-basefrom
Closed
Adopt sanitizers from @score_cpp_policies#7saksham-chawla wants to merge 3 commits intocodex/replay-pr-182-basefrom
saksham-chawla wants to merge 3 commits intocodex/replay-pr-182-basefrom
Conversation
saksham-chawla
pushed a commit
that referenced
this pull request
Mar 18, 2026
…_implementation_Feedback_Review Generic skeleton implementation feedback review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt Centralized Sanitizer Policies from
@score_cpp_policiesThis pull request refactors the project's Bazel build system to adopt centralized sanitizer policies from the external
@score_cpp_policiesmodule. It removes a significant amount of local boilerplate related to AddressSanitizer (ASan), ThreadSanitizer (TSan), UndefinedBehaviorSanitizer (UBSan), and LeakSanitizer (LSan) configurations, including build rules, test workspaces, and environment templates. The project now leverages the external module for core sanitizer setup, while retaining a mechanism for project-specific suppressions.Architecture Diagram:
flowchart TD subgraph Build_System M["MODULE.bazel (+10 lines)"] SCP["@score_cpp_policies"] QSB["quality/sanitizer/BUILD (+7 lines)"] QSSB["quality/sanitizer/sanitizer.bazelrc (+32 lines)"] end subgraph Integration_Testing QISSB["quality/integration_testing/sanitizer_support/BUILD (+10 lines)"] QIIB["quality/integration_testing/integration_testing.bzl (+4 lines)"] AT["Application_Tests (-12 lines)"] end M -->|adds dependency| SCP QSSB -->|imports configs from| SCP QSB -->|defines local suppressions| QISSB QISSB -->|combines suppressions from| SCP QIIB -->|uses configs from| SCP QIIB -->|uses suppressions from| QISSB AT -->|uses integration_test rule| QIIBThis summary was automatically generated by @propel-code-bot