-
Notifications
You must be signed in to change notification settings - Fork 0
process: DR-005 POC #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: codex/replay-pr-52-base
Are you sure you want to change the base?
Changes from all commits
2540925
4fd9060
7b42d07
96f9adf
d21f463
d5d7355
2bedaf5
aa4c4ee
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -28,11 +28,22 @@ bazel_dep(name = "platforms", version = "1.0.0") | |||||||||||||||||
| # S-CORE process rules | ||||||||||||||||||
| bazel_dep(name = "score_bazel_platforms", version = "0.0.3") | ||||||||||||||||||
| bazel_dep(name = "score_docs_as_code", version = "2.2.0") | ||||||||||||||||||
| git_override( | ||||||||||||||||||
| module_name = "score_docs_as_code", | ||||||||||||||||||
| commit = "9132272642711b06a8f3f6e07183506e0f9e4603", | ||||||||||||||||||
| remote = "https://github.com/etas-contrib/score_docs-as-code.git", | ||||||||||||||||||
| ) | ||||||||||||||||||
| bazel_dep(name = "score_tooling", version = "1.0.4") | ||||||||||||||||||
| bazel_dep(name = "score_rust_policies", version = "0.0.3") | ||||||||||||||||||
|
|
||||||||||||||||||
| bazel_dep(name = "score_process", version = "1.4.0", dev_dependency = True) | ||||||||||||||||||
| bazel_dep(name = "score_process", version = "1.4.3", dev_dependency = True) | ||||||||||||||||||
| bazel_dep(name = "score_platform", version = "0.5.1", dev_dependency = True) | ||||||||||||||||||
| git_override( | ||||||||||||||||||
| module_name = "score_platform", | ||||||||||||||||||
| commit = "7f07f2382aeddd218d0e091ffe3198c913819a8c", | ||||||||||||||||||
| remote = "https://github.com/etas-contrib/score_score.git", | ||||||||||||||||||
| ) | ||||||||||||||||||
|
|
||||||||||||||||||
|
|
||||||||||||||||||
| # Toolchains and extensions | ||||||||||||||||||
| bazel_dep(name = "score_toolchains_gcc", version = "0.5", dev_dependency = True) | ||||||||||||||||||
|
|
@@ -43,9 +54,10 @@ bazel_dep(name = "score_toolchains_rust", version = "0.4.0", dev_dependency = Tr | |||||||||||||||||
| bazel_dep(name = "score_crates", version = "0.0.6") | ||||||||||||||||||
|
|
||||||||||||||||||
| # Overrides | ||||||||||||||||||
| # update to same version as baselib | ||||||||||||||||||
| git_override( | ||||||||||||||||||
| module_name = "score_tooling", | ||||||||||||||||||
| commit = "612d6f180a9bb6338de5f0e6667fcf83068d9c37", #until 1.0.5 is released | ||||||||||||||||||
| commit = "8894fe5440436a8c6d9e214c97b18d619c7f7eac", | ||||||||||||||||||
| remote = "https://github.com/eclipse-score/tooling.git", | ||||||||||||||||||
| ) | ||||||||||||||||||
|
|
||||||||||||||||||
|
|
@@ -92,20 +104,27 @@ use_repo(toolchains_qnx, "toolchains_qnx_ifs") | |||||||||||||||||
|
|
||||||||||||||||||
| bazel_dep(name = "googletest", version = "1.17.0.bcr.1") | ||||||||||||||||||
| bazel_dep(name = "rapidjson", version = "1.1.0") | ||||||||||||||||||
| bazel_dep(name = "score_communication", version = "0.1.2") | ||||||||||||||||||
| git_override( | ||||||||||||||||||
| module_name = "score_communication", | ||||||||||||||||||
| commit = "5a70133dd8bd632f5c07f200a5ee4bc9f507c23b", | ||||||||||||||||||
| remote = "https://github.com/eclipse-score/communication.git", | ||||||||||||||||||
| ) | ||||||||||||||||||
| # bazel_dep(name = "score_communication", version = "0.1.2") | ||||||||||||||||||
| # git_override( | ||||||||||||||||||
| # module_name = "score_communication", | ||||||||||||||||||
| # commit = "5a70133dd8bd632f5c07f200a5ee4bc9f507c23b", | ||||||||||||||||||
| # remote = "https://github.com/eclipse-score/communication.git", | ||||||||||||||||||
| # ) | ||||||||||||||||||
|
Comment on lines
+107
to
+112
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Reliability] Commenting out
Suggested change
Context for AgentsChain of Thought
Reasoning The comment claims that commenting out Evidence found:
The comment correctly identifies that commenting out the Evidence Summary 1. File Snapshot (HEAD)
2. File Snapshot (BASE)
3. File Snapshot (HEAD)
4. File Snapshot (BASE)
5. File Lookup
6. File Lookup
7. File Snapshot (BASE)
8. File Snapshot (BASE)
9. File Snapshot (BASE)
10. File Snapshot (HEAD)
|
||||||||||||||||||
|
|
||||||||||||||||||
| bazel_dep(name = "score_baselibs", version = "0.2.0") | ||||||||||||||||||
| git_override( | ||||||||||||||||||
| module_name = "score_baselibs", | ||||||||||||||||||
| commit = "3c65b223e9f516f95935bb4cd2e83d6088ca016f", | ||||||||||||||||||
| remote = "https://github.com/eclipse-score/baselibs.git", | ||||||||||||||||||
| commit = "c8402e0304f8c1d4e48afd33909713718f697fec", | ||||||||||||||||||
| remote = "https://github.com/etas-contrib/score_baselibs.git", | ||||||||||||||||||
| ) | ||||||||||||||||||
|
|
||||||||||||||||||
|
|
||||||||||||||||||
| # Rust dependencies | ||||||||||||||||||
|
|
||||||||||||||||||
| bazel_dep(name = "score_baselibs_rust", version = "0.0.3") | ||||||||||||||||||
| git_override( | ||||||||||||||||||
| module_name = "score_baselibs_rust", | ||||||||||||||||||
| commit = "7bfda59d5e9a7dab25c4bcd546eb16b5bc43edbc", | ||||||||||||||||||
| remote = "https://github.com/etas-contrib/score_baselibs_rust.git", | ||||||||||||||||||
| ) | ||||||||||||||||||
|
|
||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,146 @@ | ||
| .. | ||
| # ******************************************************************************* | ||
| # Copyright (c) 2025 Contributors to the Eclipse Foundation | ||
| # | ||
| # See the NOTICE file(s) distributed with this work for additional | ||
| # information regarding copyright ownership. | ||
| # | ||
| # This program and the accompanying materials are made available under the | ||
| # terms of the Apache License Version 2.0 which is available at | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # ******************************************************************************* | ||
|
|
||
| .. _component_architecture_data_router_recorder: | ||
|
|
||
| data_router_recorder Component Architecture | ||
| =========================================== | ||
|
|
||
| .. document:: data_router_recorder Architecture | ||
| :id: doc__data_router_recorder_architecture | ||
| :status: draft | ||
| :safety: ASIL_B | ||
| :security: NO | ||
| :realizes: wp__component_arch | ||
| :tags: template | ||
|
|
||
| .. attention:: | ||
| The above directive must be updated according to your needs. | ||
|
|
||
| - Modify ``Your Component Name`` to be your Component Name | ||
| - Modify ``id`` to be your Component Name in upper snake case preceded by ``doc__`` and followed by ``_architecture`` | ||
| - Adjust ``status`` to be ``valid`` | ||
| - Adjust ``safety`` and ``tags`` according to your needs | ||
|
|
||
| Overview | ||
| -------- | ||
| <Brief summary> | ||
|
|
||
| Requirements Linked to Component Architecture | ||
| --------------------------------------------- | ||
|
|
||
| .. code-block:: none | ||
|
|
||
| .. needtable:: Overview of Component Requirements | ||
| :style: table | ||
| :columns: title;id | ||
| :filter: search("comp_arch_sta__archdes$", "fulfils_back") | ||
| :colwidths: 70,30 | ||
|
|
||
| Description | ||
| ----------- | ||
|
|
||
| <General Description> | ||
|
|
||
| <Design Decisions - For the documentation of the decision the :need:`gd_temp__change_decision_record` can be used.> | ||
|
|
||
| <Design Constraints> | ||
|
|
||
| Rationale Behind Architecture Decomposition | ||
| ******************************************* | ||
|
|
||
| Mandatory: A motivation for the decomposition or reason for not further splitting it into internal components. | ||
|
|
||
| .. note:: Common decisions across components / cross cutting concepts is at the higher level. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Documentation] Fix grammar: use a plural verb and hyphenation, e.g., "Common decisions across components or cross-cutting concepts are at the higher level." Note: The same template text with the same grammar issue also appears in:
Context for AgentsChain of Thought
Reasoning The comment flags a grammar issue on line 65 of Current text: "Common decisions across components / cross cutting concepts is at the higher level." Issues identified by the comment:
Both grammar corrections are valid. The suggested fix — "Common decisions across components or cross-cutting concepts are at the higher level." — is clear and actionable. Diff responsibility: The file is entirely new (added in this PR), confirmed by the base commit returning "file not found." This issue is introduced by this PR, not pre-existing debt. Additional context: The same template text with the same grammar error appears in at least three other new files added by this PR:
The comment is accurate, actionable (provides specific corrected text), and addresses an issue introduced by this PR. Evidence Summary 1. File Snapshot (HEAD)
2. File Snapshot (HEAD)
3. File Snapshot (HEAD)
|
||
|
|
||
| Static Architecture | ||
| ------------------- | ||
|
|
||
| The components are designed to cover the expectations from the feature architecture | ||
| (i.e. if already exists a definition it should be taken over and enriched). | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Documentation] Fix grammar: "if already exists a definition" should be "if a definition already exists". Note: the same phrase also appears in Context for AgentsChain of Thought
Reasoning The comment correctly identifies a grammar issue on line 71 of the newly added file. The phrase "if already exists a definition" uses non-standard English word order and should be "if a definition already exists." The file is entirely new (not found in base), so this issue is introduced by this PR. The same problematic phrase also appears in other new template files added by this PR (e.g., docs/recorders/docs/architecture/index.rst line 71). The comment is accurate, specific, and actionable—it identifies the exact text and provides the corrected wording. Evidence Summary 1. File Snapshot (HEAD)
2. File Snapshot (HEAD)
3. File Snapshot (HEAD)
|
||
|
|
||
| .. comp:: data_router_recorder | ||
| :id: comp__data_router_recorder | ||
| :security: YES | ||
| :safety: ASIL_B | ||
| :status: invalid | ||
| :implements: logic_arc_int__log_cpp__recorder, logic_arc_int__logging__buffer | ||
|
|
||
| .. needarch:: | ||
| :scale: 50 | ||
| :align: center | ||
|
|
||
| {{ draw_component(need(), needs) }} | ||
| .. | ||
| TEMPLATE: Uncomment and fill out the following comp_arc_sta directive: | ||
|
|
||
| .. comp_arc_sta:: Component Name (Static View) | ||
| :id: comp_arc_sta__component_name__static_view | ||
| :security: YES | ||
| :safety: ASIL_B | ||
| :status: invalid | ||
| :implements: logic_arc_int__feature_name__interface_name1 | ||
| :fulfils: comp_req__component_name__some_title | ||
| :includes: comp_arc_sta__component_name__2 | ||
|
|
||
| .. needarch:: | ||
| :scale: 50 | ||
| :align: center | ||
|
|
||
| {{ draw_component(need(), needs) }} | ||
|
|
||
| Dynamic Architecture | ||
| -------------------- | ||
|
|
||
| .. | ||
| TEMPLATE: Uncomment and customize the comp_arc_dyn directive: | ||
|
|
||
| .. comp_arc_dyn:: Dynamic View | ||
| :id: comp_arc_dyn__component_name__dynamic_view | ||
| :security: YES | ||
| :safety: ASIL_B | ||
| :status: invalid | ||
| :fulfils: comp_req__component_name__some_title | ||
|
|
||
| Put here a sequence diagram | ||
|
|
||
|
|
||
| Interfaces | ||
| ---------- | ||
|
|
||
|
|
||
| Internal Components | ||
| ------------------- | ||
|
|
||
| .. | ||
| TEMPLATE: Uncomment and customize the comp_arc_sta directive: | ||
|
|
||
| .. comp_arc_sta:: Component Name Static View | ||
| :id: comp_arc_sta__component_name__2 | ||
| :status: invalid | ||
| :safety: ASIL_B | ||
| :security: YES | ||
| :fulfils: comp_req__component_name__some_title | ||
| :implements: logic_arc_int__feature_name__interface_name1 | ||
|
|
||
| No architecture but detailed design | ||
|
|
||
| .. note:: | ||
| Architecture can be split into multiple files. At component level the public interfaces to be used by the user and tester to be shown. | ||
|
|
||
| .. attention:: | ||
| The above directives must be updated according to your component architecture. | ||
|
|
||
| - Replace the example content by the real content (according to :need:`gd_guidl__arch_design`) | ||
| - Set the status to valid and start the review/merge process | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Maintainability] Several
git_overrideentries now point toetas-contribforks (score_docs-as-code.git,score_score.git,score_baselibs.git,score_baselibs_rust.git) instead of the canonicaleclipse-scoreGitHub org. If this is intentional for a POC, these should be reverted before merging tomain— otherwise the build depends on forks that may diverge, be deleted, or have different access controls, breaking reproducibility for all contributors.Is this intended to be temporary? If so, add a
# TODO: revert to eclipse-score before mergecomment, or gate behind a local override mechanism.Context for Agents
Chain of Thought
Reasoning
The comment is factually accurate and highly actionable.
Evidence:
eclipse-score(the canonical org) or had no git_override at all.etas-contribfork references:score_docs_as_code→etas-contrib/score_docs-as-code.git(new override)score_platform→etas-contrib/score_score.git(new override)score_baselibs→etas-contrib/score_baselibs.git(changed fromeclipse-score/baselibs.git)score_baselibs_rust→etas-contrib/score_baselibs_rust.git(new override)Introduced by this PR: Yes, 100%. None of these etas-contrib references existed in BASE.
PR context: The title "process: DR-005 POC" confirms this is a proof of concept, which makes the comment's concern about these being temporary even more relevant.
Actionability: The comment provides two concrete actions:
eclipse-scorebefore merging to main# TODO: revert to eclipse-score before mergecomments, or use a local override mechanismThis is a critical review finding for build reproducibility and supply chain integrity.
Evidence Summary
1. File Snapshot (BASE)
MODULE.bazel2. File Snapshot (HEAD)
MODULE.bazel