Prevent rendering Text while GlyphsGeometry is not ready #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, because of three.js
src\renderers\WebGLRenderer.jslogic and the default instanceCount of InstancedBufferGeometry being Infinity, the renderer will attempt to render an infinite number of triangle whileGlyphsGeometrywait for its first call to updateGlyphs.This results in three.js WebGL.info displaying "Infinity" next to the triangle counter.
infinite.mp4
This also cause WebGLRenderer to try to make a render call with something that isn't ready, calling different binding etc as there is no early exit in the current state.
In this PR by setting instanceCount to 0 and drawRange to (0, 0) in the constructor, it'll guarantee that three.js WebGLRenderer early exit the render call for the current Text.
It should slighly improve the time to first render of the Text even though it's already barely noticeable while also preventing this confusing "Infinity" in the webgl infos whenever a new Text is added.