Conversation
…-combinespw modes going forwards
…ul solint, rather than totally being unflagged, works with the per-SPW/BB caltable updates
Owner
Author
|
It occurred to me, as I was creating this PR, that we used to allow the inf_EB to do a per-SPW unflagging, and this update kills that. I will try to fix that now. |
erikvcarlson
pushed a commit
to erikvcarlson/auto_selfcal
that referenced
this pull request
May 5, 2024
Heuristics updates, potentially for Fall 2023 release (mosaics + long baselines)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe, though it has now been some time so my memory is a little fuzzy, that this initially came about because once the per-SPW/BB caltables were added, there was a case where the initial attempt at calibration picked either per-SPW or per-BB as the preferred mode. That solution failed, so it did the combinespw fallback and still failed because of a beam-size change. It thus did the "calonly" fallback, but because the combinespw fallback had failed, per-SPW and per-BB were still options. I don't recall which mode it ultimately picked, but regardless, my recollection is that the selfcal actually continued successfully, and it didn't break until the weblog. At that point, because unflagging had been done, when the weblog looped over all modes for that solint, it was looking for the "*.pre-pass" version of the gaintable, but could only find it for the preferred mode and therefore crashed.
After some thought, I decided that the simplest solution would be that in the event that we reached the "calonly" fallback, that only the combinespw option should be considered, and all other modes should be removed for future solints (resetting for ap solints).
It also, as I was working on this, occurred to me that the option for antennas to fall back to previous successful solint solutions rather than being "passed through" should only consider previous combinespw solints, as others all get applied. It would also make for very confusing code/gaintables to be mixing per-spw and not...
This PR fixes both of those issues.