add a promote to the SigFig macro to handle other expressions #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstaabp
pushed a commit
that referenced
this pull request
Oct 28, 2025
Fix issues noted in my review of openwebwork#1266.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #25 (comment) @dpvc noted that if SigFigs are passed to subroutines that have non-sigfig numbers that those other numbers will be promoted to sig figs. In general, this is not what is wanted (see the average function in the link above.)
This adds a promote to the SignificantFigures::Real package that will promote non-sig fig numbers to have infinite sig figs.