Skip to content

[PULP-715] Add JSON-based Simple API #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2025
Merged

[PULP-715] Add JSON-based Simple API #956

merged 1 commit into from
Nov 6, 2025

Conversation

@jobselko
Copy link
Contributor

@jobselko jobselko commented Sep 4, 2025

closes #625

@jobselko jobselko self-assigned this Sep 4, 2025
@github-actions github-actions bot added no-changelog multi-commit Add to bypass single commit lint check no-issue labels Sep 4, 2025
@jobselko jobselko force-pushed the close_625 branch 2 times, most recently from 16f7486 to 03e61c7 Compare September 8, 2025 21:52
@github-actions github-actions bot removed the multi-commit Add to bypass single commit lint check label Sep 8, 2025
@jobselko jobselko force-pushed the close_625 branch 2 times, most recently from c7e19ec to 6647217 Compare September 8, 2025 22:06
gerrod3
gerrod3 reviewed Sep 14, 2025
View reviewed changes
Copy link
Contributor

@gerrod3 gerrod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks like it is coming along well.

@jobselko jobselko force-pushed the close_625 branch 5 times, most recently from 5ad38d9 to 597818e Compare September 24, 2025 09:02
gerrod3
gerrod3 requested changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@gerrod3 gerrod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple changes left.

dralley
dralley reviewed Oct 30, 2025
View reviewed changes
dralley
dralley reviewed Oct 31, 2025
View reviewed changes
pulp_python/app/models.py Outdated
python_version = models.TextField()
sha256 = models.CharField(db_index=True, max_length=64)
sha256_metadata = models.CharField(max_length=64)
yanked = models.BooleanField(default=False)
Copy link
Contributor

@dralley dralley Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gerrod3 So, I take it that the python plugin does not have "immutable" content, since "yanked" is explicitly mutable?

The yanked attribute is not immutable once set, and may be rescinded in the future (and once rescinded, may be reset as well). Thus API users MUST be able to cope with a yanked file being “unyanked” (and even yanked again).

Copy link
Contributor

@gerrod3 gerrod3 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't know what to do with the field. I decided to originally not implement it since it's mutable and only useful per repository. Maybe we can do something similar to pulp_ansible and add a new yanked content type that's presence in the repository tells us the content should be yanked. For now let's remove the field and deal with it later.

@github-actions github-actions bot added the multi-commit Add to bypass single commit lint check label Nov 3, 2025
@jobselko jobselko force-pushed the close_625 branch 5 times, most recently from ed76616 to fff96d2 Compare November 4, 2025 07:39
@github-actions github-actions bot removed the multi-commit Add to bypass single commit lint check label Nov 4, 2025
@jobselko jobselko force-pushed the close_625 branch 2 times, most recently from 546e0ad to b0d5dc8 Compare November 4, 2025 16:00
@github-actions github-actions bot added the multi-commit Add to bypass single commit lint check label Nov 4, 2025
@jobselko jobselko force-pushed the close_625 branch 8 times, most recently from e113dee to 9b0c4b3 Compare November 5, 2025 22:29
@jobselko jobselko force-pushed the close_625 branch 2 times, most recently from 7812757 to 7916e65 Compare November 5, 2025 22:58
@github-actions github-actions bot added multi-commit Add to bypass single commit lint check and removed multi-commit Add to bypass single commit lint check labels Nov 5, 2025
@github-actions github-actions bot removed multi-commit Add to bypass single commit lint check no-issue labels Nov 6, 2025
@jobselko jobselko requested review from dralley and gerrod3 November 6, 2025 13:26
gerrod3
gerrod3 approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@gerrod3 gerrod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great work! Thank you @jobselko 🎉

dralley
dralley reviewed Nov 6, 2025
View reviewed changes
dralley
dralley reviewed Nov 6, 2025
View reviewed changes
dralley
dralley reviewed Nov 6, 2025
View reviewed changes
dralley
dralley reviewed Nov 6, 2025
View reviewed changes
@dralley dralley merged commit c08fcb2 into pulp:main Nov 6, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dralley dralley dralley approved these changes

@gerrod3 gerrod3 gerrod3 approved these changes

Assignees

@jobselko jobselko

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[PULP-713] Add support for new JSON simple index

3 participants

@jobselko @dralley @gerrod3