Skip to content

[PULP-817] Adjustments to make imp/exp work with django-imp-exp 4.x. #6973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggainey merged 1 commit into from
Jan 5, 2026
Merged

[PULP-817] Adjustments to make imp/exp work with django-imp-exp 4.x. #6973

ggainey merged 1 commit into from
Jan 5, 2026

Conversation

@ggainey
Copy link
Contributor

@ggainey ggainey commented Sep 23, 2025

closes #5324.

@ggainey
Copy link
Contributor Author

ggainey commented Sep 23, 2025

May require plugin-changes to adapt to django-import-export:4.x - DO NOT MERGE until 3.100.

@ggainey ggainey force-pushed the django_impexp_4 branch 2 times, most recently from 922ff33 to d2916d8 Compare September 23, 2025 18:56
mdellweg
mdellweg reviewed Sep 24, 2025
View reviewed changes
pulpcore/app/modelresource.py
Comment on lines +65 to +66
if row[checksum] == "" or checksum not in settings.ALLOWED_CONTENT_CHECKSUMS:
del row[checksum]
Copy link
Member

@mdellweg mdellweg Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random unrelated question: Do we recalculate missing checksums on import? Or do both systems need the same setting there?

Copy link
Contributor Author

@ggainey ggainey Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine question, and the answers are "no we don't" and "...huh." I expect that, "in the wild", systems being exported-to have the same settings as the system being exported-from, so it just never came up. But it's a de-facto standard, not a de-jure one :)

@ggainey ggainey mentioned this pull request Sep 30, 2025
Closed
@ggainey ggainey force-pushed the django_impexp_4 branch 2 times, most recently from 31b150e to 605dd8a Compare September 30, 2025 18:23
@stale
Copy link

stale bot commented Dec 29, 2025

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

@stale stale bot added the stale label Dec 29, 2025
@stale
Copy link

stale bot commented Jan 5, 2026

This pull request is no longer marked for closure.

@stale stale bot removed the stale label Jan 5, 2026
@ggainey ggainey marked this pull request as ready for review January 5, 2026 16:14
@ggainey ggainey force-pushed the django_impexp_4 branch 2 times, most recently from 9b936b1 to 38e20f4 Compare January 5, 2026 16:20
@pedro-psb
Copy link
Member

pedro-psb commented Jan 5, 2026

🤞

@ggainey ggainey requested review from mdellweg and pedro-psb January 5, 2026 17:15
@ggainey ggainey enabled auto-merge (rebase) January 5, 2026 17:16
pedro-psb
pedro-psb reviewed Jan 5, 2026
View reviewed changes
Copy link
Member

@pedro-psb pedro-psb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought. Wdyt?

pedro-psb
pedro-psb approved these changes Jan 5, 2026
View reviewed changes
Copy link
Member

@pedro-psb pedro-psb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ggainey ggainey merged commit 793c0ad into pulp:main Jan 5, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedro-psb pedro-psb pedro-psb approved these changes

@mdellweg mdellweg Awaiting requested review from mdellweg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[PULP-422] Make the import/export machinery compatible with django-import-export>=4.0

3 participants

@ggainey @pedro-psb @mdellweg