Skip to content

Add to sidebar context #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add to sidebar context #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccc7d9f
🔧 Update Permissions
PressJump Jan 7, 2023
8e5bd5a
✨ Context Menu Option for Adding to Sidebar
PressJump Jan 7, 2023
8df2c0d
🍱 Update Extension Icon
PressJump Jan 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion icon.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions js/background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,3 +122,24 @@ browser.runtime.onMessage.addListener(({ type, data }, sender) => {

return null
})

// =============================================================================
// Context Menu Logic

const sidebartabs = browser.menus.create({
title: 'Add to Sidebar',
contexts: ['page'],
Copy link
Member

@trickypr trickypr Jan 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, if I right click in a blank part of the page, I can add the page to the sidebar, but if I right click on the tab I cannot. If I right click on selected text I cannot.

Also, shouldn't I be able to right click on a link to add it to the sidebar? That was what I thought this was itnened to fix at first.

Please review the valid context menu types: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/menus/ContextType

Copy link
Member Author

@PressJump PressJump Jan 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm the link adding to sidebar sounds like a cool addition. I thought it was the page itself but will change to add both.

documentUrlPatterns: ['*://*/*'],
})

browser.menus.onClicked.addListener(function (info, tab) {
switch (info.menuItemId) {
case sidebartabs:
createSidebarItem({
title: tab.title,
iconUrl: tab.favIconUrl,
webviewUrl: tab.url,
})
break
}
})
5 changes: 4 additions & 1 deletion manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@
"tabs",
"webRequest",
"activeTab",
"https://icons.duckduckgo.com/"
"https://icons.duckduckgo.com/",
"menus",
"<all_urls>",
"contextMenus"
],
"web_accessible_resources": [
"icon.svg",
Expand Down