Conversation
|
/run-acceptance-tests |
| @@ -0,0 +1,43 @@ | |||
| <?xml version="1.0"?> | |||
There was a problem hiding this comment.
Thank you for the review , present configuration is only for local development it is not set for CI but i will make changes for CI.
justinvp
left a comment
There was a problem hiding this comment.
Thanks, @kjswaruph! Here's some additional suggestions.
sdk/java/pulumi/src/main/java/com/pulumi/automation/events/internal/package-info.java
Outdated
Show resolved
Hide resolved
sdk/java/pulumi/src/main/java/com/pulumi/automation/events/package-info.java
Outdated
Show resolved
Hide resolved
sdk/java/pulumi/src/main/java/com/pulumi/automation/serialization/internal/package-info.java
Outdated
Show resolved
Hide resolved
sdk/java/pulumi/src/main/java/com/pulumi/automation/package-info.java
Outdated
Show resolved
Hide resolved
sdk/java/pulumi/src/main/java/com/pulumi/resources/ResourceOptions.java
Outdated
Show resolved
Hide resolved
- Added class level description and method level descriptions to improve Javadoc coverage
- Added new files package-info.java for package descriptions - Specified in descriptions if a package is not meant for external use
- add the checkstyle plugin in sdk/java/pulumi/build.gradle - Add checkstyle configurations checkstyle.xml and suppressions.xml ins sdk/java/config/checkstyle/
7af0a18 to
501bfee
Compare
Co-authored-by: Justin Van Patten <jvp@justinvp.com>
|
Hello, I need help regarding this issue. If I try to build after adding checkstyle plugin, the checkstyle triggers the task :pulumi:compilePubJava, which fails due to missing dependencies and generated sources. I checked if this task is present in main branch it didnt perform the task. To work around this, I disabled the compilePubJava task with Here's the output I get when i try to build with checkstyle plugin: https://pastebin.com/z5G6WjTF |
|
@justinvp @tgummerer please help
|
Solves #1663
Changes: