Conversation
Member
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Feb 27, 2026
corymhall
changed the title
corymhall
force-pushed
the
st-ac3.17.3.6.1-maxitems-rename-normalization
branch
from
b7a0038 to
a1a7b82
Compare
corymhall
force-pushed
the
st-ac3.17.3.7-finalize-goldens-harness-docs
branch
from
c45c4a0 to
cedeaf8
Compare
corymhall
force-pushed
the
st-ac3.17.3.6.1-maxitems-rename-normalization
branch
from
a1a7b82 to
599b8b7
Compare
corymhall
force-pushed
the
st-ac3.17.3.7-finalize-goldens-harness-docs
branch
from
cedeaf8 to
33ce676
Compare
corymhall
force-pushed
the
st-ac3.17.3.6.1-maxitems-rename-normalization
branch
from
599b8b7 to
6c7341a
Compare
corymhall
force-pushed
the
st-ac3.17.3.7-finalize-goldens-harness-docs
branch
from
33ce676 to
27431e1
Compare
Zaid-Ajaj
approved these changes
Mar 2, 2026
corymhall
force-pushed
the
st-ac3.17.3.6.1-maxitems-rename-normalization
branch
from
6c7341a to
9204a23
Compare
corymhall
force-pushed
the
st-ac3.17.3.7-finalize-goldens-harness-docs
branch
from
27431e1 to
b8af9b1
Compare
corymhall
force-pushed
the
st-ac3.17.3.6.1-maxitems-rename-normalization
branch
from
9204a23 to
fb61a2b
Compare
corymhall
force-pushed
the
st-ac3.17.3.7-finalize-goldens-harness-docs
branch
from
b8af9b1 to
9dc5e27
Compare
corymhall
force-pushed
the
st-ac3.17.3.6.1-maxitems-rename-normalization
branch
from
fb61a2b to
36c0bb9
Compare
corymhall
force-pushed
the
st-ac3.17.3.7-finalize-goldens-harness-docs
branch
from
9dc5e27 to
1617f5b
Compare
corymhall
added a commit
that referenced
this pull request
Mar 2, 2026
…#110) ## Summary This PR integrates field/type lookup decisions into compare generation and simplifies command-layer behavior accordingly. It removes reliance on downstream shaping assumptions by making the engine classification path authoritative. ## What Changed - Integrated field/type equivalence checks into compare engine type-change handling. - Tightened type-equivalence handling for map/value shape edge cases. - Updated text rendering and cmd tests to validate one-pass behavior. - Kept command flow focused on rendering result data instead of semantic reinterpretation. ## Why Field/type normalization decisions should happen during change generation, not after rendering. This keeps output deterministic and reduces fragile command-layer logic. ## Context - Depends on #108 lookup primitives and #109 token integration. - Enables final rename-aware and fixture parity work in #111/#112. ## Testing - `go test ./internal/compare ./compare ./internal/cmd -count=1`
corymhall
force-pushed
the
st-ac3.17.3.6.1-maxitems-rename-normalization
branch
from
36c0bb9 to
692d99c
Compare
corymhall
force-pushed
the
st-ac3.17.3.7-finalize-goldens-harness-docs
branch
from
1617f5b to
68d96bc
Compare
corymhall
force-pushed
the
st-ac3.17.3.6.1-maxitems-rename-normalization
branch
from
692d99c to
b969162
Compare
corymhall
force-pushed
the
st-ac3.17.3.7-finalize-goldens-harness-docs
branch
from
68d96bc to
0fca1f5
Compare
corymhall
force-pushed
the
st-ac3.17.3.7-finalize-goldens-harness-docs
branch
3 times, most recently
from
fabe893 to
76ad7da
Compare
corymhall
added a commit
that referenced
this pull request
Mar 2, 2026
…111) ## Summary This PR improves rename-aware and maxItems-related transition handling using real AWS fixture coverage. It focuses on turning noisy or split diagnostics into clearer single-cause type/rename messages where metadata evidence supports that outcome. ## What Changed - Added real AWS normalization fixture tests and fixture data. - Added/updated normalization helpers for rename-aware field and type transitions. - Refined compare engine handling for ref/array boundary transitions. - Added coverage for type-ref token parsing and related normalization edge cases. - Updated supporting normalize/compare tests and helper wiring needed by these scenarios. ## Why Real fixture coverage is required to validate that normalization behavior matches expected user-facing diagnostics. This hardens behavior before final golden/harness consolidation. ## Context - Builds on engine integration from #110. - Feeds the final golden/harness pass in #112. > Note: I had to upgrade to Go 1.25 in this since I brought in new dependencies ## Testing - `go test ./internal/normalize ./internal/compare ./compare -count=1`
Base automatically changed from
st-ac3.17.3.6.1-maxitems-rename-normalization
to
master
March 2, 2026 16:18
Squash details: - Branch: st-ac3.17.3.7-finalize-goldens-harness-docs - Base: st-ac3.17.3.6.1-maxitems-rename-normalization - Squashed commits: 5 Original commits: - d62d2c0 Finalize structured goldens and document lookup-first invariants - 49e3e5b Finalize compare goldens and harness alignment - c75d878 cmd compare: add repo file download support - fff9d8f Process wave review: preserve diagnostics and upgrade lint - f8bfc38 compare: make JSON uncapped, text capped; tighten requiredness/remap severity
corymhall
force-pushed
the
st-ac3.17.3.7-finalize-goldens-harness-docs
branch
from
76ad7da to
43ff40a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR finalizes the compare structured-output wave by aligning contracts, goldens, and harness coverage across compare and cmd paths.
It also captures finalized output semantics for capped text rendering and full structured JSON output.
What Changed
Why
This closes the loop on behavior, tests, and documentation so reviewers can validate a stable end-state at the stack tip.
It ensures the same semantics are exercised by both compare package tests and command harness tests.
Context
closes #83
closes #84