Support Java 9 modules specific JVM arguments #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--add-modules, --add-reads, --add-exports and --add-opens can be followed by a space and the module/package it applies to. This pair is split when parsing arguments and should be recombined together. - Add a new method addJava9ModulesJvmArg with a state variable firstPartJava9ModulesArg to keep the first part of the Java 9 module argument, and so remove static qualifier of addJvmArg.
|
Hey, any chance in this getting merged or reviewed? :-) Cheers |
Author
|
Hi @pron We would need this soon for a release. Best regards |
It is called when reolving native dependencies line 2512 and when resolving boot classpath line 2281. And it happens that these functionalities are not used, it is the case in our product, and it still works perfectly. Nothing to be warned of... Change-Id: I247f59b214749e0211090f254e0a3ea5cb069389
Checking the last extraction time is after the jar file time isn't enough for development version. We have issues where we first build multiple dev versions and then test/deploy them a day after. In this case, the cache won't be cleaned up and the app classpath may be wrong. Now if you change the jar, it re-extracts. Change-Id: I9648e2ef7b7fa031b8455465c6bc605fc1c71e72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--add-modules, --add-reads, --add-exports and --add-opens can be
followed by a space and the module/package it applies to. This pair is
split when parsing arguments and should be recombined together.
firstPartJava9ModulesArg to keep the first part of the Java 9 module
argument, and so remove static qualifier of addJvmArg.