Update to PDK template 3.5.1 #814
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to c05b7c7. PDK does not add environment variables to the Gemfile unless a version is specified in .sync.yml, so this commit adds a version for beaker-hostgenerator.
Previously, beaker-puppet was unable to be installed with newer versions of Ruby. This was resolved in PA-6136, so we no longer need a conditional in .sync.yml for beaker-puppet.
Previously, the async gem needed to be pinned to 1.30 because of the version of Ruby that internal Jenkins runners were using. We are now using more modern Rubies, so we do not need to pin the gem any longer.
mhashizume
added
the
maintenance
mhashizume
force-pushed
the
PA-7820/main/pdk-update
branch
from
699837b to
85696a3
Compare
This commit updates this module to the latest PDK template (3.5.1). It also: - Addresses new Rubocop offenses associated with the update. - Updates legacy facts from puppet_agent_spec, as legacy facts were removed in newer versions of FacterDB.
mhashizume
force-pushed
the
PA-7820/main/pdk-update
branch
from
85696a3 to
725e163
Compare
|
Blocked on puppetlabs/phoenix-github-actions#30 |
|
GitHub Actions are not resolving phoenix-github-actions@main to the right commit, I'm going to close and re-open this PR in hopes that that fixes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comprises an update to the latest PDK template (3.5.1) and miscellaneous maintenance commits for the .sync.yml.