- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1.1k
Linear shade gh1690 #1725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            mikofski
  wants to merge
  13
  commits into
  pvlib:main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
mikofski:linear_shade_gh1690
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
      
        
          +168
        
        
          −4
        
        
          
        
      
    
  
  
     Open
                    Linear shade gh1690 #1725
Changes from all commits
      Commits
    
    
            Show all changes
          
          
            13 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      1bb4e7d
              
                add linear shade loss for thin films
              
              
                mikofski 778b3eb
              
                add tests, update docs, what's new
              
              
                mikofski 9ecdb0e
              
                fix what's new gh issue and pr links
              
              
                mikofski eae3bcc
              
                fix trailing whitespace
              
              
                mikofski e5a7beb
              
                Fix typo in condition for shade
              
              
                mikofski 90b4488
              
                responding to comments
              
              
                mikofski ea14adb
              
                Merge branch 'linear_shade_gh1690'
              
              
                mikofski 5f01bfe
              
                update docstring for linear shade loss
              
              
                mikofski cd3df97
              
                Merge branch 'main' into linear_shade_gh1690
              
              
                mikofski 15c197c
              
                Merge branch 'linear_shade_gh1690' of github.com:mikofski/pvlib-pytho…
              
              
                mikofski 76eefbd
              
                update example in linear_shade_loss
              
              
                mikofski dee9f12
              
                add figure and formulas to shaded fraction
              
              
                mikofski ffd9590
              
                shaded fraction consistently
              
              
                mikofski File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
      
      Loading
      
  Sorry, something went wrong. Reload?
      Sorry, we cannot display this file.
      Sorry, this file is invalid so it cannot be displayed.
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like it would be a lot easier for the user if the parameter was simply
solar_zenithand the calculation to the projected solar zenith could be done behind the scenes (there should be a function for that in pvlib somewhere).Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The calculation for psz requires at least one additional argument, the solar azimuth and is not a trivial calculation:
It is already in pvlib here:
pvlib-python/pvlib/tracking.py
Line 432 in 275e671
which made me discover a typo in the comments here:
pvlib-python/pvlib/tracking.py
Line 421 in 275e671
should be the (x, z) plane, which is corrected lower down here:
pvlib-python/pvlib/tracking.py
Line 429 in 275e671
Anyway, I agree, it would be helpful to have PSZ as it's own function. And if it already exists in addition to
tracking.py:432then we should consolidate. I think it's out of scope for this PR, though so I'll open another one for that.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created #1734 to propose a stand alone PSZ function, but in the process, realized that the existing use in
tracking.pyactually calculates the solar vector as observed in the reference frame of the tracker axes, which may be tilted north or south. So this new function would need to be generalized to different reference frames.I'm coming around to this idea. One instant advantage of this standalone function would be generalization of this linear shade loss function to arbitrary slopes that have both NS and EW tilt! Thanks! However, I still think it's best to address separately, then return to this function to enhance it with the axis tilt and the solar azimuth.