STY: Tweak PdfWriter #3337
Merged
STY: Tweak PdfWriter #3337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small changes including making method insert_blank_page more flexible.
Small changes including making method insert_blank_page more flexible.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3337 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 57 57
Lines 9807 9807
Branches 1780 1780
=======================================
Hits 9529 9529
Misses 167 167
Partials 111 111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Could you please have a look at the coverage? All (new) conditions should be covered be appropriate tests. |
stefan6419846
added
the
needs-test
Co-authored-by: Stefan <96178532+stefan6419846@users.noreply.github.com>
Small changes including making method insert_blank_page more flexible.
Small changes including making method insert_blank_page more flexible.
Small changes including making method insert_blank_page more flexible.
Contributor
Author
|
Is this PR okay? |
So this is just a style change.
stefan6419846
removed
the
needs-test
stefan6419846
requested changes
Nov 20, 2025
Collaborator
stefan6419846
left a comment
stefan6419846
left a comment
There was a problem hiding this comment.
Could we please revert all the changes to the media box handling which are not about code style, including reverting the tests? These should go into a dedicated PR.
stefan6419846
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes including making method insert_blank_page more flexible.