Merged
Conversation
sezelt
approved these changes
Jan 4, 2024
Member
sezelt
left a comment
sezelt
left a comment
There was a problem hiding this comment.
This looks like a good improvement and should improve maintainability
bsavitzky
pushed a commit
to bsavitzky/py4DSTEM
that referenced
this pull request
Mar 12, 2024
Update check_config workflow Former-commit-id: 92969ed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the check_config workflow. Taken from #560.
This PR does the following:
Updates config_checker so that it does scrapes the required modules and optional installs from setup.py and adds generic version checking for installed versions of packages. New behavior is if we add a dependency or add a new optional set of dependencies e.g. ~"dev" : ["pytest", "black", "flake8"], it will no automatically pick up on "dev" install optional and test whether all the dependencies are met, and report the state i.e. all met or not. Previously, we had to manually update by adding a dependency or optional dependencies set to a list or dict.