Fix parameter passing of calculate_CTF in parallax.depth_section#716
Open
QishanXie wants to merge 2 commits intopy4dstem:devfrom
Open
Fix parameter passing of calculate_CTF in parallax.depth_section#716QishanXie wants to merge 2 commits intopy4dstem:devfrom
calculate_CTF in parallax.depth_section#716QishanXie wants to merge 2 commits intopy4dstem:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the parallax.depth_section() function, it pumps up an error when I set the
calculate_CTF = True.This PR is to fix this:
py4DSTEM/py4DSTEM/process/phase/parallax.py
Lines 2774 to 2792 in 04e2b6b
In the function _calculate_CTF, the fourth parameter is to provide the aberration order, while in the parallax.depth_section(), it just adds the *self._aberrations_coeffs.