feat(config): allow custom Views in MetricOptions #1552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
alexmojaki
reviewed
Dec 4, 2025
| """Experimental setting to add up the values of counter and histogram metrics in active spans.""" | ||
|
|
||
| views: Sequence[View] = DEFAULT_VIEWS | ||
| """Sequence of views to be enabled for metric collection""" |
Contributor
There was a problem hiding this comment.
It should be easy to keep the default views, something like this: MetricsOptions(views=MetricsOptions.DEFAULT_VIEWS + [...])
Please also expand this docstring and add tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the FastAPI integration which exposes metrics like http.server.response.size which I want to drop.
The only way to do this seems to be to add a custom View and setting
DropAggregation: