Skip to content

Fix expand_dims string coordinate dtype inference #11069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
garg-khushi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix expand_dims string coordinate dtype inference #11069

garg-khushi wants to merge 3 commits into from
+23 −5

Conversation

@garg-khushi
Copy link

@garg-khushi garg-khushi commented Jan 5, 2026

This PR fixes an inconsistency where expand_dims created object-dtype
coordinates for string inputs instead of NumPy unicode dtype.

Changes:

  • Preserve NumPy unicode dtype for string coordinates created via expand_dims
  • Prevent object-dtype propagation through concat by improving
    PandasIndex coord dtype inference
  • Add regression tests covering both cases

Fixes #11061

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

topic-indexing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

expand_dims creates object dtype for string coordinates instead of inferring string dtype

1 participant

@garg-khushi