Skip to content

Conversation

@samukweku
Copy link
Collaborator

@samukweku samukweku commented Oct 18, 2025

PR Description

Please describe the changes proposed in the pull request:

  • improve the conditional logic in pivot_wider parameters check

This PR improves #1509

Please tag maintainers to review.

@ericmjl
Copy link
Member

ericmjl commented Oct 18, 2025

@samukweku
Copy link
Collaborator Author

Cc: @wjandrea

Copy link
Member

@ericmjl ericmjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! @samukweku I was able to review it, and I don't see any issues that need to be resolved on this pass. Approving!

@samukweku samukweku merged commit f45c305 into dev Nov 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pivot_wider() failing with unclear error: KeyError: None pivot_wider() requires names_from but the docs say it shouldn't

3 participants