-
Notifications
You must be signed in to change notification settings - Fork 72
Remove k_endog & k_exog parameters in SSM
#599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hey @jessegrabowski, after updating all the models and the regression component in the structural api the complexity of the validation code dropped quite a bit. I am looking at pulling out that VARMAX validation utility to use across all the other models (SARIMAX, ETS, DFM) but the only commonality between them is how the |
|
I was going to say yes anyway :D |
|
Jesse, I marked the two open issues for closer upon merging this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work as always! Left some feedback.
Also rebase, we just merged the Pytensor update that will fix tests.
pymc_extras/statespace/models/structural/components/regression.py
Outdated
Show resolved
Hide resolved
| return exog_dims | ||
|
|
||
|
|
||
| def _validate_endog_names(endog_names) -> int: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this to validate_names, and add a optional: bool =True argument so it can either error or return None. Then you can eliminate _get_state_names in the regression component and use this instead. Also can use it for the exog names in SARIMAX, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a var_name argument as well so that if it does raise a value error the message will clearly state what variable is missing.
… and updated tests accordingly
…exogenous variables and updated tests accordingly
…dog_names required and exog_state_names required for exogenous variables and updated tests accordingly
…quired and exog_names required if exogenous variables are requested and updated tests accordingly
…k_endog and k_exog parameters
…eused in both endog and some exog cases
9a3e24d to
330dc19
Compare
This PR is related to #589 and aims to remove redundant parameters
k_endogandk_exogfrom SSM models. The following models will be updated:In addition, this PR will also address
Closes #587
Closes #589