Fix independent_rvs determination in vectorize_over_posterior
#7890
+34
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7890 +/- ##
=======================================
Coverage 92.94% 92.94%
=======================================
Files 116 116
Lines 18851 18851
=======================================
+ Hits 17521 17522 +1
+ Misses 1330 1329 -1
🚀 New features to boost your workflow:
|
ricardoV94
reviewed
Aug 19, 2025
pymc/sampling/forward.py
Outdated
| and not ({*outputs, *independent_rvs} & set(rv_ancestors)) | ||
| and {var for var in rv_ancestors if var in all_rvs} <= {rv, *needed_rvs} | ||
| if rv not in needed_rvs and not ( | ||
| {*outputs, *needed_rvs, *independent_rvs} & set(rv_ancestors) |
There was a problem hiding this comment.
outputs / needed_rvs / independent_rvs are also the blockers store than in an intermediate variable?
There was a problem hiding this comment.
filter rv not in needed_rvs already in the list comp that starts this loop?
tests/sampling/test_forward.py
Outdated
Comment on lines
1985
to
1986
| a_ancestor1 = get_var_by_name([vectorized_no_intermediate], "a")[0] | ||
| a_ancestor2 = get_var_by_name([vectorized_intermediate_rvs], "a")[0] |
There was a problem hiding this comment.
Assuming there should only be one match:
Suggested change
| a_ancestor1 = get_var_by_name([vectorized_no_intermediate], "a")[0] | |
| a_ancestor2 = get_var_by_name([vectorized_intermediate_rvs], "a")[0] | |
| [a_ancestor1] = get_var_by_name([vectorized_no_intermediate], "a") | |
| [a_ancestor2] = get_var_by_name([vectorized_intermediate_rvs], "a") |
lucianopaz
force-pushed
the
vectorize_bug
branch
from
dcb68e6 to
4f57c50
Compare
|
Thanks for the review @ricardoV94. I applied your comments. Sorry for the long delay |
lucianopaz
force-pushed
the
vectorize_bug
branch
from
4f57c50 to
e7e36d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the determination of
independent_rvsRVs invectorize_over_posterior. I think that the fixed check is much clearer now. It says that anrvis independent if it doesn't depend on anoutput, aneeded_rv(a model freeRV that is replaced by its posterior samples), or anotherindependent_rv. To make sure the check works correctly, the candidate rv nodes are searched in the order given by their topological sort.Related Issue
vectorize_over_posteriorfails to determineindependent_rvs#7889Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7890.org.readthedocs.build/en/7890/