Conversation
Signed-off-by: William Woodruff <william@astral.sh>
|
CC @pypa/packaging-user-guide-editors |
|
It's linked to in other places unfortunately: packaging.python.org/source/guides/multi-version-installs.rst Lines 41 to 43 in 11477a6 packaging.python.org/source/guides/packaging-namespace-packages.rst Lines 288 to 289 in 11477a6 |
Grumble, thanks 🙂 |
Signed-off-by: William Woodruff <william@astral.sh>
ncoghlan
left a comment
There was a problem hiding this comment.
The "request changes" is because pkgutil based namespace packages have nothing to do with pkg_resources, so the legacy namespace package warning is misplaced.
The other suggestions are because I think we should salt this earth more thoroughly :)
Signed-off-by: William Woodruff <william@astral.sh>
|
Thanks @ncoghlan! I've applied all of your feedback 🙂 |
ncoghlan
left a comment
There was a problem hiding this comment.
LGTM, thanks! Just a small typo in the edit, which I'll commit before merging.
pkg_resourcesis no longer provided by setuptools, so this link is dead (and breaks the build). I've removed the link but kept the term itself, along with a mention of the removal.Ref: https://discuss.python.org/t/pkg-resources-removal-how-to-go-from-there/106079
📚 Documentation preview 📚: https://python-packaging-user-guide--2002.org.readthedocs.build/en/2002/