-
Notifications
You must be signed in to change notification settings - Fork 286
Add pylock select function #1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
6c391aa
3cb4609
5a19f68
40455b9
a70e129
dd87b98
63cfe1d
b7e2df1
47c397f
a0256b2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ | |
|
|
||
| lock-version = '1.0' | ||
| environments = ['sys_platform == "win32"', 'sys_platform == "linux"'] | ||
| requires-python = '==3.12' | ||
| requires-python = '==3.12.*' | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here I think the example from the spec needs to be changed as it does not work when checking against
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is that because it uses
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can't check what pip does right now, but since it's a specifier,
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pip uses |
||
| created-by = 'mousebender' | ||
|
|
||
| [[packages]] | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brettcannon why is it an error if a package requires-python is not satisfied? Should it not be skipped in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's for when https://packaging.python.org/en/latest/specifications/pylock-toml/#requires-python has been satisfied but somehow a specific package claims otherwise. When I wrote that I'm sure my brain was assuming
requires-pythonwould be set ifpackages.requires-pythonwas set.