Skip to content

fix(pylock): check that url and path match if name is not set#1117

Merged
henryiii merged 2 commits intopypa:mainfrom
sbidoul:pylock-check-url-path-match
Mar 17, 2026
Merged

fix(pylock): check that url and path match if name is not set#1117
henryiii merged 2 commits intopypa:mainfrom
sbidoul:pylock-check-url-path-match

Conversation

@sbidoul
Copy link
Member

@sbidoul sbidoul commented Mar 11, 2026

No description provided.

"wheels": [
{
"path": "./that-1.0-py3-none-any.whl",
"url": "http://example.com/that-1.0-py3-none-any.whl",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here path and url names are identical but don't match package name. This passes here but is detected by #1114

@henryiii henryiii changed the title pylock: check that url and path match if name is not set fix(pylock): check that url and path match if name is not set Mar 17, 2026
@henryiii henryiii merged commit 00b7e75 into pypa:main Mar 17, 2026
56 checks passed
@sbidoul
Copy link
Member Author

sbidoul commented Mar 18, 2026

I should maybe have kept this as draft as the d.p.o discussion and pypa/packaging.python.org#2018 are going in a different direction.

@henryiii I see you changed the title to fix(pylock), but it is not really a fix, it's rather a new validation check.

@sbidoul
Copy link
Member Author

sbidoul commented Mar 18, 2026

So I suggest reverting this one. I'll prepare another PR when pypa/packaging.python.org#2018 is merged.

@henryiii
Copy link
Contributor

The prefix there is to indicate where in the changelog the change should go. I'll probably merge all the pylock related things, so feat might be okay. I'd consider it more of a fix, though. fix is a modification to behavior, rather than new behavior. There's also chore, ci, refactor, perf, and docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants