Open
Conversation
Merge remote-tracking branch 'upstream/develop' into develop
merge with upstream
Collaborator
|
Hi @opkuhn . I changed the base branch to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is merely to add the pypeit file, lbt_luci2_G210K.pypeit, that can be used to reduce the sample dataset, luci2_G210K, in the shared google drive.
The pypeit file refers to a wavelength calibration template. The lbt_luci.py in develop makes use of G200+zJ/HK templates for LUCI1 and LUCI2, but does not refer to a G210+K wavelength template. This one could be added, though I'd like to try to improve its RMS first.