Open
Conversation
# Conflicts: # pypeit/spectrographs/gemini_gmos.py
# Conflicts: # doc/releases/1.16.1dev.rst # pypeit/flatfield.py
Co-authored-by: Debora Pelliccia <dpelliccia@ucolick.org>
Spatial flexure reorganisation
# Conflicts: # doc/releases/1.17.1dev.rst
# Conflicts: # doc/releases/1.17.1dev.rst # presentations/py/users.py # pypeit/wavetilts.py
# Conflicts: # doc/calibrations/flexure.rst # doc/releases/1.17.2dev.rst # pypeit/core/flexure.py # pypeit/images/rawimage.py # pypeit/par/pypeitpar.py
debora-pe
reviewed
Dec 20, 2024
pypeit/images/rawimage.py
Outdated
| if self.par['spat_flexure_correct'] else None | ||
| self.spat_flexure_shift = None | ||
| if self.par['spat_flexure_method'] != "skip" or not np.ma.is_masked(manual_spat_flexure): | ||
| self.spat_flexure_shift = self.spatial_flexure_shift(slits, method=self.par['spat_flexure_method'], |
Collaborator
There was a problem hiding this comment.
Hey @rcooke-ast . Just a little confusion here.
maxlagis not a parameter ofself.spatial_flexure_shift()anymore.self.par['spat_flexure_maxlag']is passed directly toflexure.spat_flexure_shift()- you can do the same with
method. Since it is defined inself.par, you can just pass it directly toflexure.spat_flexure_shift()
Collaborator
Author
There was a problem hiding this comment.
Ah, yes, good call! I'll update it 👍
# Conflicts: # doc/pypeit_par.rst # doc/releases/1.17.2dev.rst # pypeit/calibrations.py
# Conflicts: # deprecated/find_objects.py # deprecated/flat.py # deprecated/ql_keck_lris.py # deprecated/ql_multislit.py # deprecated/reduce.py # doc/releases/1.17.2dev.rst # presentations/py/users.py # pypeit/coadd2d.py # pypeit/par/pypeitpar.py # pypeit/pypeit.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reworks a lot of the code that uses spatial flexure. The main change here is that instead of a single value, the spatial flexure is now stored for each slit edge. I haven't yet implemented the edge-by-edge spatial flexure adjustment. These updates are just to ensure that the code base is unaffected by the change from a single floating point value to a 2D array.
There is a matching PR in the dev-suite. I'm running tests now...